Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-136-accumulo@git.apache.org>
In-Reply-To: <git-pr-136-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #136: Accumulo 2971: improvements to ChangeSecret Tool
Content-Type: text/plain
Message-Id: <20160728183633.9F121E0100@git1-us-west.apache.org>
Date: Thu, 28 Jul 2016 18:36:33 +0000 (UTC)
archived-at: Thu, 28 Jul 2016 18:36:35 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/136#discussion_r72677493
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/ChangeSecret.java ---
    @@ -63,12 +66,15 @@ public static void main(String[] args) throws Exception {
         Instance inst = opts.getInstance();
         if (!verifyAccumuloIsDown(inst, opts.oldPass))
           System.exit(-1);
    -    String instanceId = rewriteZooKeeperInstance(inst, opts.oldPass, opts.newPass);
    -    updateHdfs(fs, inst, instanceId);
    +    if (!verifyHdfsWritePermission(fs))
    +      System.exit(-1);
    --- End diff --
    
    Ah, I missed the message in verifyHdfsWritePermission.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---