Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ivakegg <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-134-accumulo@git.apache.org>
In-Reply-To: <git-pr-134-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #134: ACCUMULO-4391 Added synchronization around the a...
Content-Type: text/plain
Message-Id: <20160728182259.742EAE0100@git1-us-west.apache.org>
Date: Thu, 28 Jul 2016 18:22:59 +0000 (UTC)
archived-at: Thu, 28 Jul 2016 18:23:01 -0000

Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/134#discussion_r72674888
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java ---
    @@ -62,12 +62,15 @@ public BoundedRangeFileInputStream(FSDataInputStream in, long offset, long lengt
     
       @Override
       public int available() throws IOException {
    -    int avail = in.available();
    -    if (pos + avail > end) {
    -      avail = (int) (end - pos);
    -    }
    +    final FSDataInputStream inLocal = in;
    +    synchronized (inLocal) {
    +      int avail = inLocal.available();
    --- End diff --
    
    I am considering this, but others had commented to me that adhering to the API as close as possible was a good thing.  However if we state clearly that this class does not, then avoid the synchronization altogether would be great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---