Return-Path: <dev-return-15529-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 52027200B4C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 22 Jul 2016 20:43:50 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 5093C160A6D; Fri, 22 Jul 2016 18:43:50 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BE341160A5A
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 22 Jul 2016 20:43:49 +0200 (CEST)
Received: (qmail 41663 invoked by uid 500); 22 Jul 2016 18:43:48 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 41648 invoked by uid 99); 22 Jul 2016 18:43:48 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jul 2016 18:43:48 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 88843E058E; Fri, 22 Jul 2016 18:43:48 +0000 (UTC)
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-133-accumulo@git.apache.org>
In-Reply-To: <git-pr-133-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #133: ACCUMULO-4388: Move location to obtain zoo sessi...
Content-Type: text/plain
Message-Id: <20160722184348.88843E058E@git1-us-west.apache.org>
Date: Fri, 22 Jul 2016 18:43:48 +0000 (UTC)
archived-at: Fri, 22 Jul 2016 18:43:50 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/133#discussion_r71926509
  
    --- Diff: fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java ---
    @@ -155,20 +162,30 @@ public ZooCache(ZooReader reader, Watcher watcher) {
     
       private abstract class ZooRunnable<T> {
         /**
    -     * Runs an operation against ZooKeeper, automatically retrying in the face of KeeperExceptions
    +     * Runs an operation against ZooKeeper. Retries are performed by the retry method when KeeperExceptions occur.
    +     *
    +     * Changes were made in ACCUMULO-4388 so that the run method no longer accepts Zookeeper as an argument, and instead relies on the ZooRunnable
    +     * implementation to call getZookeeper. Performing the call to retrieving a ZooKeeper Session after caches are checked has the benefit of limiting ZK
    --- End diff --
    
    s/getZookeeper/{@link #getZooKeeper()}/, but that can be changed on merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---