Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-120-accumulo@git.apache.org>
In-Reply-To: <git-pr-120-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #120: ACCUMULO-4324 update data version
Content-Type: text/plain
Message-Id: <20160713151059.C3662E04BE@git1-us-west.apache.org>
Date: Wed, 13 Jul 2016 15:10:59 +0000 (UTC)
archived-at: Wed, 13 Jul 2016 15:11:01 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/120#discussion_r70644711
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java ---
    @@ -68,7 +72,7 @@
       public static final int LOGGING_TO_HDFS = 4;
       public static final BitSet CAN_UPGRADE = new BitSet();
       static {
    -    for (int i : new int[] {DATA_VERSION, MOVE_TO_ROOT_TABLE, MOVE_DELETE_MARKERS, LOGGING_TO_HDFS}) {
    +    for (int i : new int[] {DATA_VERSION, MOVE_TO_REPLICATION_TABLE, MOVE_TO_ROOT_TABLE, MOVE_DELETE_MARKERS, LOGGING_TO_HDFS}) {
    --- End diff --
    
    bq. My gut reaction is to not worry about 1.5, but is there any fundamental problem in supporting that (is it just a testing burden)?
    
    Yeah its just a matter of testing it.  I am not completely sure, but it seems code may be in place to support that upgrade. I don't know if it works.   Personally I would not want to support it w/o testing it.
    
    bq. If we don't support a direct upgrade from 1.5, what's the fail-safe? 
    
    Could add support for it in 1.8.1 or later if someone really wants that functionality.
    
    > Could users just bulk-import the old files into a new instance?
    
    That's tricky, if done incorrectly can resurrect old and/or deleted data.
    
    Also before making any definitive decisions about 1.5 and earlier, we should see if the 1.6 to 1.8 upgrade uncovers any interesting issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---