accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivakegg <...@git.apache.org>
Subject [GitHub] accumulo pull request #134: ACCUMULO-4391 Added synchronization around the a...
Date Wed, 27 Jul 2016 18:05:43 GMT
Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/134#discussion_r72491410
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
    @@ -62,12 +62,15 @@ public BoundedRangeFileInputStream(FSDataInputStream in, long offset,
long lengt
     
       @Override
       public int available() throws IOException {
    -    int avail = in.available();
    -    if (pos + avail > end) {
    -      avail = (int) (end - pos);
    -    }
    +    final FSDataInputStream inLocal = in;
    +    synchronized (inLocal) {
    +      int avail = in.available();
    --- End diff --
    
    According to InputStream, this returns an estimate of the number of bytes that can be
read (or skipped over) without blocking by the next invocation of a method for this input
stream.  A single read or skip of this many bytes will not block, but may read or skip fewer
bytes.
    So we have to delegate this to the underlying stream.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message