accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #133: ACCUMULO-4388: Move location to obtain zoo sessi...
Date Fri, 22 Jul 2016 18:43:57 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/133#discussion_r71926540
  
    --- Diff: fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java ---
    @@ -155,20 +162,30 @@ public ZooCache(ZooReader reader, Watcher watcher) {
     
       private abstract class ZooRunnable<T> {
         /**
    -     * Runs an operation against ZooKeeper, automatically retrying in the face of KeeperExceptions
    +     * Runs an operation against ZooKeeper. Retries are performed by the retry method
when KeeperExceptions occur.
    +     *
    +     * Changes were made in ACCUMULO-4388 so that the run method no longer accepts Zookeeper
as an argument, and instead relies on the ZooRunnable
    +     * implementation to call getZookeeper. Performing the call to retrieving a ZooKeeper
Session after caches are checked has the benefit of limiting ZK
    +     * connections and blocking as a result of obtaining these sessions.
    +     *
    +     * @return T the result of the runnable
          */
    -    abstract T run(ZooKeeper zooKeeper) throws KeeperException, InterruptedException;
    +    abstract T run() throws KeeperException, InterruptedException;
     
    +    /**
    +     * Retry will attempt to call the run method. Run should make a call to getZooKeeper()
after checks to cached information are made. This change, per
    --- End diff --
    
    javadoc link comment here as well would be good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message