accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #131: ACCUMULO-4356 Remove bundled jars from -bin.tar....
Date Fri, 22 Jul 2016 16:08:38 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/131#discussion_r71903919
  
    --- Diff: assemble/src/main/scripts/generate-download-script.sh ---
    @@ -0,0 +1,56 @@
    +#! /usr/bin/env bash
    +
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +# This script will generate a DEPENDENCIES listing of packaged dependencies
    +
    +in=target/dependencies.raw.txt
    +out=target/download-dependencies
    +
    +cat >"$out" <<'EOF'
    +#! /usr/bin/env bash
    +# This script downloads the following jars, identified by their maven
    +# coordinates, using the maven-dependency-plugin.
    +#
    +# DISCLAIMER: This is only one possible way to download a set of dependencies
    +# for your class path. This is not guaranteed to download the versions of
    +# dependencies you require for your particular installation of Accumulo. It is recommended
    +# that you consider your class path carefully, and determine which dependencies
    +# are suitable for your needs.
    +
    +DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
    +
    +cat >"$DIR/VERSIONS" <<'HEAD'
    +This file is GENERATED and lists the versions of the dependencies downloaded by
    +the download-dependencies script when it was last run, in the form:
    +
    +  <groupId>:<artifactId>:<version>
    +
    +HEAD
    +
    +downloadDependency () {
    +  echo "Downloading to $DIR/$1 ..."
    +  echo "  $1" >>"$DIR/VERSIONS"
    +  mvn org.apache.maven.plugins:maven-dependency-plugin:2.10:copy -Dartifact="$1" -Dmdep.stripVersion=true
-DoutputDirectory="$DIR"
    +}
    +
    +EOF
    +
    +for x in $(grep '^   [a-z]' "$in"); do
    --- End diff --
    
    I think we can assume it will always exist, because it's built by a previous part of the
maven build... but if we messed up, I suppose it wouldn't fail the build. Grep will just print
something to stderr about the file not existing, and the for loop will turn into a noop because
it had no input strings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message