accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #130: ACCUMULO-4382 Clean up license/notice files
Date Fri, 22 Jul 2016 02:41:53 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/130#discussion_r71819704
  
    --- Diff: server/base/src/main/javadoc/META-INF/NOTICE ---
    @@ -1,5 +0,0 @@
    -Apache Accumulo
    -Copyright 2011-2016 The Apache Software Foundation
    --- End diff --
    
    The appropriate LICENSE/NOTICE file are automatically placed in the javadoc jar. The only
reason to override is if the javadoc jar needs something different than the source or binary
jars. In the case of the server-base module, it doesn't, so these weren't doing anything helpful.
It was just extra. Removing them makes it behave just like the gc or start jars, which don't
have anything special (special == bundled external code) either.
    
    The only modules which require something special in their jars are core (for bloom filter
stuffs) and monitor (for jquery/flot).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message