accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo issue #125: ACCUMULO-4375 Add missing byte[]-based Key constructors
Date Mon, 18 Jul 2016 12:41:58 GMT
Github user keith-turner commented on the issue:

    https://github.com/apache/accumulo/pull/125
  
    @melrief this looks good.  The behavior is consistent w/ the Text constructors, which
is really nice.  Looking at the test and javadoc you added inspired me to open [ACCUMULO-4377](https://issues.apache.org/jira/browse/ACCUMULO-4377).
 Adding the test for copy behavior is more general than this PR, since existing constructors
do not have those test.
    
    @melrief one additional thing thats needed is `@since 1.8.0` tags.   Would you be interested
in doing another PR to add those?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message