accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From melrief <...@git.apache.org>
Subject [GitHub] accumulo pull request #125: ACCUMULO-4375 Add missing byte[]-based Key const...
Date Sun, 17 Jul 2016 17:36:09 GMT
Github user melrief commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/125#discussion_r71086057
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/data/Key.java ---
    @@ -107,6 +107,17 @@ public Key(Text row) {
       }
     
       /**
    +   * Creates a key with the specified row, empty column family, empty column qualifier,
empty column visibility, timestamp {@link Long#MAX_VALUE}, and delete
    +   * marker false.
    --- End diff --
    
    Done, now each method has a note
    
    ```java
    This constructor creates a copy of each specified array. If you don't want to create a
copy of the arrays, you should call
       * {@link Key#Key(byte[] row, byte[] cf, byte[] cq, byte[] cv, long ts, boolean deleted,
boolean copy)} instead.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message