accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From melrief <...@git.apache.org>
Subject [GitHub] accumulo pull request #125: ACCUMULO-4375 Add missing byte[]-based Key const...
Date Sun, 17 Jul 2016 16:53:01 GMT
Github user melrief commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/125#discussion_r71085502
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/data/Key.java ---
    @@ -107,6 +107,17 @@ public Key(Text row) {
       }
     
       /**
    +   * Creates a key with the specified row, empty column family, empty column qualifier,
empty column visibility, timestamp {@link Long#MAX_VALUE}, and delete
    +   * marker false.
    --- End diff --
    
    I'll do it. I wonder if this is the right behaviour or if the user would expect the byte
array to be used as it is. In my version of this that I'm using at work, I'm setting `copy`
to false all the time because I know that's safe considering how I'm using the arrays. When
I submitted this patch, I decided to switch to true because it was more safe. Maybe we should
add this parameter to each constructor using `byte[]` explicitly so that the user knows that
he can avoid copying the array?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message