accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #125: ACCUMULO-4375 Add missing byte[]-based Key const...
Date Sun, 17 Jul 2016 16:41:35 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/125#discussion_r71085334
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/data/Key.java ---
    @@ -107,6 +107,17 @@ public Key(Text row) {
       }
     
       /**
    +   * Creates a key with the specified row, empty column family, empty column qualifier,
empty column visibility, timestamp {@link Long#MAX_VALUE}, and delete
    +   * marker false.
    --- End diff --
    
    I think adding a Javadoc comment to your method additions (all of them, not just this
one) that explicitly state that they copy the provided byte arrays is important. This can
be a big performance impact -- you could point to the `Key(byte[] row, byte[] cf, byte[] cq,
byte[] cv, long ts, boolean deleted, boolean copy)` constructor which does allow users to
control whether or not the constructor will do a copy of the provided byte arrays.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message