accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #120: ACCUMULO-4324 update data version
Date Wed, 13 Jul 2016 17:23:08 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/120#discussion_r70669365
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/log/WalStateManager.java
---
    @@ -98,10 +102,16 @@ private String root() {
       // Tablet server exists
       public void initWalMarker(TServerInstance tsi) throws WalMarkerException {
         byte[] data = new byte[0];
    -    try {
    -      zoo.putPersistentData(root() + "/" + tsi.toString(), data, NodeExistsPolicy.FAIL);
    -    } catch (KeeperException | InterruptedException e) {
    -      throw new WalMarkerException(e);
    +    while (true) {
    +      try {
    +        zoo.putPersistentData(root() + "/" + tsi.toString(), data, NodeExistsPolicy.FAIL);
    +        break;
    +      } catch (NoNodeException e) {
    +        log.info("WAL parent node does not exist (upgrade may be in progress) : " + e.getMessage());
    --- End diff --
    
    @ShawnWalker   made a very nice suggestion irc.  Create the WALs node instead of waiting.
 This breaks this invisible dependency on code in the master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message