accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #122: ACCUMULO-1604: added check for negate option in ...
Date Mon, 11 Jul 2016 01:40:39 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/122#discussion_r70193707
  
    --- Diff: core/src/test/java/org/apache/accumulo/core/iterators/user/FilterTest.java ---
    @@ -208,9 +208,9 @@ public void test2() throws IOException {
         a = a.deepCopy(null);
         SortedKeyValueIterator<Key,Value> copy = a.deepCopy(null);
         a.seek(new Range(), EMPTY_COL_FAMS, false);
    -    assertEquals(size(a), 900);
    +    assertEquals(900, size(a));
    --- End diff --
    
    Separating out these test fixes into a separate commit (with a separate JIRA) would make
me happy as it makes the changeset easier to comprehend if we ever need to go back in history,
but I'm not -1 either if you don't.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message