accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhutchis <...@git.apache.org>
Subject [GitHub] accumulo pull request #122: ACCUMULO-1604: added check for negate option in ...
Date Wed, 06 Jul 2016 04:56:26 GMT
Github user dhutchis commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/122#discussion_r69675388
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/user/ColumnAgeOffFilter.java
---
    @@ -43,6 +43,9 @@ public TTLSet(Map<String,String> objectStrings) {
           for (Entry<String,String> entry : objectStrings.entrySet()) {
             String column = entry.getKey();
             String ttl = entry.getValue();
    +        // skip the negate option, it will cause an exception to be thrown
    +        if (column.equals(NEGATE))
    --- End diff --
    
    A user might want to use this filter on a column named NEGATE. Could you add a condition
`&& !TTL.equalsIgnoreCase("true") && !ttl.equalsIgnoreCase("false")`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message