Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-110-accumulo@git.apache.org>
In-Reply-To: <git-pr-110-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #110: ACCUMULO-4328: Run multiple tablet servers per h...
Content-Type: text/plain
Message-Id: <20160607150051.0EC3ADFF32@git1-us-west.apache.org>
Date: Tue,  7 Jun 2016 15:00:51 +0000 (UTC)
archived-at: Tue, 07 Jun 2016 15:00:53 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/110#discussion_r66087817
  
    --- Diff: assemble/bin/start-daemon.sh ---
    @@ -103,9 +90,61 @@ ERRFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_${LOGHOST}.err"
     rotate_log "$OUTFILE" ${ACCUMULO_NUM_OUT_FILES}
     rotate_log "$ERRFILE" ${ACCUMULO_NUM_OUT_FILES}
     
    -# Fork the process, store the pid
    -nohup ${NUMA_CMD} "$COMMAND" "${SERVICE}" --address "${ADDRESS}" >"$OUTFILE" 2>"$ERRFILE" < /dev/null &
    -echo $! > ${PID_FILE}
    +if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
    +   # Check the pid file to figure out if its already running.
    +   PID_FILE="${ACCUMULO_PID_DIR}/accumulo-${ACCUMULO_IDENT_STRING}-${SERVICE}.pid"
    +   if [ -f ${PID_FILE} ]; then
    +      PID=`cat ${PID_FILE}`
    +      if kill -0 $PID 2>/dev/null; then
    +         # Starting an already-started service shouldn't be an error per LSB
    +         echo "$HOST : $SERVICE already running (${PID})"
    +         exit 0
    +      fi
    +   fi
    +   echo "Starting $SERVICE on $HOST"
    +
    +   # Fork the process, store the pid
    +   nohup ${NUMA_CMD} "$COMMAND" "${SERVICE}" --address "${ADDRESS}" >"$OUTFILE" 2>"$ERRFILE" < /dev/null &
    +   echo $! > ${PID_FILE}
    +
    +else
    +
    --- End diff --
    
    Could have a sanity check on `TSERVER_NUMA_OPTIONS` to check that if it exists its length is equal to `NUM_TSERVERS`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---