accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From georgekankava <...@git.apache.org>
Subject [GitHub] accumulo pull request #118: Multiple code improvements - squid:1213, squid:S...
Date Tue, 21 Jun 2016 08:55:42 GMT
GitHub user georgekankava opened a pull request:

    https://github.com/apache/accumulo/pull/118

    Multiple code improvements - squid:1213, squid:S2275, squid:SwitchLastCaseIsDefaultCheck,
squid:UselessImportCheck, squid:ClassVariableVisibilityCheck

    This pull request is focused on resolving occurrences of Sonar rules
    squid:S1213 - The members of an interface declaration or class should appear in a pre-defined
order.
    squid:S2275 - Printf-style format strings should not lead to unexpected behavior at runtime.
    squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause.
    squid:UselessImportCheck - Useless imports should be removed.
    squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility.
    This pull request removes technical debt of 168 minutes.
    You can find more information about the issue here:
    https://dev.eclipse.org/sonar/rules/show/squid:S1213
    https://dev.eclipse.org/sonar/rules/show/squid:S2275
    https://dev.eclipse.org/sonar/rules/show/squid:SwitchLastCaseIsDefaultCheck
    https://dev.eclipse.org/sonar/rules/show/squid:UselessImportCheck
    https://dev.eclipse.org/sonar/rules/show/squid:ClassVariableVisibilityCheck
    Please let me know if you have any questions.
    George Kankava

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DevFactory/accumulo release/multiple-code-improvements-fix-4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
    
----
commit a6f3bd94aa8a4c54d36bcd8ce2423b3a4f6d96cc
Author: George Kankava <george.kankava@devfactory.com>
Date:   2016-06-21T06:53:08Z

    Multiple code improvements - squid:1213, squid:S2275, squid:SwitchLastCaseIsDefaultCheck,
squid:UselessImportCheck, squid:ClassVariableVisibilityCheck

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message