accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From georgekankava <...@git.apache.org>
Subject [GitHub] accumulo pull request #117: Multiple code improvements - squid:SwitchLastCas...
Date Tue, 21 Jun 2016 08:47:26 GMT
GitHub user georgekankava opened a pull request:

    https://github.com/apache/accumulo/pull/117

    Multiple code improvements - squid:SwitchLastCaseIsDefaultCheck, squid:S1197, squid:S1192,
squid:S2131

    This pull request is focused on resolving occurrences of Sonar rules
    squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause.
    squid:S1197 - Array designators "[]" should be on the type, not the variable.
    squid:S1192 - String literals should not be duplicated.
    squid:S2131 - Primitives should not be boxed just for "String" conversion.
    This pull request removes technical debit of 80 minutes.
    You can find more information about the issue here:
    https://dev.eclipse.org/sonar/rules/show/squid:SwitchLastCaseIsDefaultCheck
    https://dev.eclipse.org/sonar/rules/show/squid:S1197
    https://dev.eclipse.org/sonar/rules/show/squid:S1192
    https://dev.eclipse.org/sonar/rules/show/squid:S2131
    Please let me know if you have any questions.
    George Kankava

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DevFactory/accumulo release/multiple-code-improvements-fix-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit d7131a123bd07a873fd37f0c2eddad251217cb85
Author: George Kankava <george.kankava@devfactory.com>
Date:   2016-06-20T15:21:19Z

    Multiple code improvements - squid:SwitchLastCaseIsDefaultCheck, squid:S1197, squid:S1192,
squid:S2131

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message