accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From georgekankava <...@git.apache.org>
Subject [GitHub] accumulo pull request #114: Multiple code improvements - squid:S1118, squid:...
Date Tue, 21 Jun 2016 08:29:03 GMT
GitHub user georgekankava opened a pull request:

    https://github.com/apache/accumulo/pull/114

    Multiple code improvements - squid:S1118, squid:S1155, squid:ClassVariableVisibilityCheck,
squid:MissingDeprecatedCheck, squid:S1186

    This pull request is focused on resolving occurrences of Sonar rules
    squid:S1118 - Utility classes should not have public constructors.
    squid:S1155 - Collection.isEmpty() should be used to test for emptiness.
    squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility.
    squid:MissingDeprecatedCheck - Deprecated elements should have both the annotation and
the Javadoc tag.
    squid:S1186 - Methods should not be empty.
    This pull request removes technical debt of 69 minutes.
    You can find more information about the issue here:
    https://dev.eclipse.org/sonar/rules/show/squid:S1118
    https://dev.eclipse.org/sonar/rules/show/squid:S1155
    https://dev.eclipse.org/sonar/rules/show/squid:ClassVariableVisibilityCheck
    https://dev.eclipse.org/sonar/rules/show/squid:MissingDeprecatedCheck
    https://dev.eclipse.org/sonar/rules/show/squid:S1186
    Please let me know if you have any questions.
    George Kankava

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DevFactory/accumulo release/multiple-code-improvements-fix-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #114
    
----
commit 18d11ed4c4a30bfb517bdb50b4064c91b8d17aa6
Author: George Kankava <george.kankava@devfactory.com>
Date:   2016-06-20T13:43:28Z

    Multiple code improvements - squid:S1118, squid:S1155, squid:ClassVariableVisibilityCheck,
squid:MissingDeprecatedCheck, squid:S1186

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message