accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #121: ACCUMULO-4353: Stabilize tablet assignment durin...
Date Thu, 30 Jun 2016 23:53:26 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/121#discussion_r69229399
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
    @@ -543,6 +546,9 @@
       TABLE_SAMPLER_OPTS("table.sampler.opt.", null, PropertyType.PREFIX,
           "The property is used to set options for a sampler.  If a sample had two options
like hasher and modulous, then the two properties "
               + "table.sampler.opt.hasher=${hash algorithm} and table.sampler.opt.modulous=${mod}
would be set."),
    +  TABLE_SUSPEND_DURATION("table.suspend.duration", "0s", PropertyType.TIMEDURATION,
    +      "For tablets belonging to this table: When a tablet server dies, allow the tablet
server this duration to revive before reassigning its tablets"
    +          + "to other tablet servers."),
    --- End diff --
    
    Looking at the patch it seems that normal tablets always go from ASSIGNED_TO_DEAD->SUSPENDED->UNASSIGNED.
 Is it correct that there is no optimization for the case when this property is 0 to go directly
from ASSIGNED_TO_DEAD->UNASSIGNED?  I am not advocating for this,  I am just trying to
make sure I am properly understanding the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message