accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #114: Multiple code improvements - squid:S1118, squid:...
Date Tue, 21 Jun 2016 15:13:39 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/114#discussion_r67888116
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java ---
    @@ -82,12 +82,20 @@ public Authorizations convert(String value) {
       }
     
       public static class Password {
    -    public byte[] value;
    +    private byte[] value;
    --- End diff --
    
    This should likely be private final, otherwise, you'll need to deal with the correctness
of copying a reference to an array.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message