accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlmarion <...@git.apache.org>
Subject [GitHub] accumulo pull request #111: ACCUMULO-4331: first draft
Date Tue, 14 Jun 2016 16:17:50 GMT
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/111#discussion_r67003317
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java ---
    @@ -374,15 +374,17 @@ private static void stopTabletServer(final ClientContext context,
List<String> s
         final String zTServerRoot = getTServersZkPath(instance);
         final ZooCache zc = new ZooCacheFactory().getZooCache(instance.getZooKeepers(), instance.getZooKeepersSessionTimeOut());
         for (String server : servers) {
    -      HostAndPort address = AddressUtil.parseAddress(server, context.getConfiguration().getPort(Property.TSERV_CLIENTPORT));
    -      final String finalServer = qualifyWithZooKeeperSessionId(zTServerRoot, zc, address.toString());
    -      log.info("Stopping server " + finalServer);
    -      MasterClient.execute(context, new ClientExec<MasterClientService.Client>()
{
    -        @Override
    -        public void execute(MasterClientService.Client client) throws Exception {
    -          client.shutdownTabletServer(Tracer.traceInfo(), context.rpcCreds(), finalServer,
force);
    -        }
    -      });
    +      for (int port : context.getConfiguration().getPort(Property.TSERV_CLIENTPORT))
{
    --- End diff --
    
    Good catch, I wonder how long that has been around.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message