accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo pull request #111: ACCUMULO-4331: first draft
Date Thu, 09 Jun 2016 18:38:20 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/111#discussion_r66497618
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ---
    @@ -168,8 +168,8 @@ public static void init(VolumeManager fs, ServerConfigurationFactory
serverConfi
         logConfigWatcher.start();
     
         // Makes sure the log-forwarding to the monitor is configured
    -    int logPort = conf.getPort(Property.MONITOR_LOG4J_PORT);
    -    System.setProperty("org.apache.accumulo.core.host.log.port", Integer.toString(logPort));
    +    int logPort[] = conf.getPort(Property.MONITOR_LOG4J_PORT);
    --- End diff --
    
    Can you put brackets after the type instead of the variable?  This is form is valid but
[discouraged](https://docs.oracle.com/javase/tutorial/java/nutsandbolts/arrays.html).  This
occurs a couple different times in the PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message