accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #110: ACCUMULO-4328: Run multiple tablet servers per h...
Date Tue, 07 Jun 2016 14:59:10 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/110#discussion_r66087448
  
    --- Diff: assemble/bin/accumulo ---
    @@ -151,10 +151,23 @@ fi
     # Export the variables just in case they are not exported
     # This makes them available to java
     export JAVA_HOME HADOOP_PREFIX ZOOKEEPER_HOME LD_LIBRARY_PATH DYLD_LIBRARY_PATH
    +
    +# Strip the instance from $1
    +APP=$1
    +INSTANCE="1"
    +if [[ "$1" =~ .*-.* ]]; then
    +  APP=`echo $1 | cut -d"-" -f1`
    +  INSTANCE=`echo $1 | cut -d"-" -f2`
    --- End diff --
    
    
    Should any validation of `INSTANCE` be done?  Could ensure its an integer >=1.  Maybe
also check that its <= NUM_TSERVERS, I am not sure if check makes sense here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message