accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #107: ACCUMULO-4157 Bug fix for removing WALs to quick...
Date Thu, 02 Jun 2016 16:02:02 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/107#discussion_r65568599
  
    --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
---
    @@ -55,12 +56,16 @@
     import org.apache.zookeeper.KeeperException;
     
     import com.google.common.net.HostAndPort;
    +import java.util.concurrent.TimeUnit;
    +import org.apache.accumulo.core.conf.Property;
     
     public class GarbageCollectWriteAheadLogs {
       private static final Logger log = Logger.getLogger(GarbageCollectWriteAheadLogs.class);
     
       private final Instance instance;
       private final VolumeManager fs;
    +  private final Map<HostAndPort,Long> firstSeenDead = new HashMap<HostAndPort,Long>();
    --- End diff --
    
    The safety of this not being a concurrent/synchronized map is likely due to the use of
GCWALogs by the SimpleGarbageCollector? Maybe we just need to document that this class is
not threadsafe now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message