accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4153: Update the getCodec method to no longe...
Date Tue, 31 May 2016 23:50:14 GMT
Github user keith-turner commented on the pull request:

    https://github.com/apache/accumulo/pull/105
  
    I just took a quick look at this, I am going to look at it more in the morning.  One thing
I dont understand is that all the impl createCompressionStream and createDecompressionStream
methods are synchronized. Maybe that because they are mutating the conf, but it seems the
conf is scoped wider than the sync.  Also, is this a bottleneck?  I will look into it more
in the morning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message