accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4165 Added a user facing API for RFile
Date Tue, 31 May 2016 16:59:43 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/103
  
    >>    I see you didn't switch over the AccumuloFileOutputFormat to use this new
API. I would have considered that exercise good validation of the API that you made here.
Thoughts?
    
    > I did consider that, but didn't get to it.
    
    Should that be interpreted as "I will not get to it" or "I have not yet gotten to it"?
I'm not sure if I would be -1 without it, but I do think it would be very important to actually
switch over to that new API for two reasons:
    
    1. Further validates the correctness and usability of your API
    2. Potentially prevents us having more issues switching to it in the 1.8.x maintenance
line. Maybe we could swap it in later without users noticing, but I would be worried about
unintended consequences cropping up.
    
    Ideally, it should be very trivial, and I could do this on my own to help out if you don't
have the time to do so on your own, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message