accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4165 Added a user facing API for RFile
Date Tue, 31 May 2016 16:56:12 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/103#discussion_r65221323
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/FileOperations.java ---
    @@ -278,9 +288,20 @@ public RateLimiter getRateLimiter() {
       /**
        * Operation object for constructing a writer.
        */
    -  protected class OpenWriterOperation extends FileIOOperation<OpenWriterOperation>
implements OpenWriterOperationBuilder {
    +  protected class OpenWriterOperation extends FileIOOperation<OpenWriterOperation>
implements OpenWriterOperationBuilder,
    +      NeedsFileOrOuputStream<OpenWriterOperationBuilder> {
         private String compression;
    +    private FSDataOutputStream outputStream;
     
    +    @Override
    +    public NeedsTableConfiguration<OpenWriterOperationBuilder> forOutputStream(String
extenstion, FSDataOutputStream outputStream, Configuration fsConf) {
    +      this.outputStream = outputStream;
    +      setConfiguration(fsConf);
    +      setFilename("foo" + extenstion);
    --- End diff --
    
    Glad I mentioned it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message