accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4318 Made writers and scanners auto closeabl...
Date Tue, 31 May 2016 15:07:27 GMT
Github user keith-turner commented on the pull request:

    https://github.com/apache/accumulo/pull/104
  
    > Maybe close by GC is wrong (I forget if we actually have a finalizer on it now).
But, anyways, you added some close calls on Scanners :)
    
    ok.  Introducing Autocloseable introduced lots of warnings in the code.  I was just trying
to suppress the warnings.   When I did this I was thinking Scanners don't have to be closed,
so don't need to use try-with-resources.  However this could change in the future and the
warnings will not be there.  I'll change those to use try-with-resources.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message