accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Date Wed, 25 May 2016 20:13:16 GMT
Github user ctubbsii commented on the pull request:

    https://github.com/apache/accumulo/pull/101#issuecomment-221692951
  
    Spoke with Mike and made some suggestions. In summary:
    
    Pros
    * I like the improvements to the menu layout.
    * I like the simplified footer.
    * I like the image being moved into the menu.
    * I like the removal of the search box. It wasn't very useful, I think.
    * I like the removal of the left side social buttons on most pages.
    
    Cons
    * I don't think the index.md file needs to be renamed to index.html. It's still being
processed as a Markdown file, because it has front-matter. Best to keep the filename consistency,
I think, even if it currently doesn't contain markdown syntax. (Also easier to see the diff.)
    * Menu doesn't resize quickly enough to the "mobile" view when the window shrinks. Might
be best to shorten "Apache Software Foundation" or shrink the text size or something.
    * "Apache License, Version 2.0" needs non-breaking spaces `&nbsp;` so it doesn't get
broken up when window shrinks.
    * I think the left-side social buttons shouldn't appear on the first page either. Instead,
it should be moved to the footer. Or, at the very least, they should be made smaller without
the large text next to them (hover text is sufficient).
    * Nav bar getting bigger by X pixels means that the `h1::before`, etc. style needs to
also increase by X pixels so section headers don't get hidden under the menu when navigating
directly to a section.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message