accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...
Date Tue, 24 May 2016 04:04:57 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/100#discussion_r64325773
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java ---
    @@ -89,6 +90,10 @@ private RFile() {}
       static final int RINDEX_VER_8 = 8; // Added sample storage. There is a sample locality
group for each locality group. Sample are built using a Sampler and
                                          // sampler configuration. The Sampler and its configuration
are stored in RFile. Persisting the method of producing the
                                          // sample allows a user of RFile to determine if
the sample is useful.
    +                                     //
    +                                     // Selected smaller keys for index by doing two
things. First internal stats were used to look for keys that were below
    +                                     // average in size for the index. Also keys that
were statically large were excluded from the index. Second shorter keys
    --- End diff --
    
    s/statically/statistically/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message