Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-96-accumulo@git.apache.org>
In-Reply-To: <git-pr-96-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-4229 BatchWriter Locator
 cache out...
Content-Type: text/plain
Message-Id: <20160424232136.BA472DFE61@git1-us-west.apache.org>
Date: Sun, 24 Apr 2016 23:21:36 +0000 (UTC)

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/96#discussion_r60853748
  
    --- Diff: test/src/test/java/org/apache/accumulo/test/BatchWriterInTabletServerIT.java ---
    @@ -0,0 +1,120 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.test;
    +
    +import com.google.common.collect.Iterators;
    +import org.apache.accumulo.core.client.BatchWriter;
    +import org.apache.accumulo.core.client.BatchWriterConfig;
    +import org.apache.accumulo.core.client.Connector;
    +import org.apache.accumulo.core.client.IteratorSetting;
    +import org.apache.accumulo.core.client.Scanner;
    +import org.apache.accumulo.core.data.Key;
    +import org.apache.accumulo.core.data.Mutation;
    +import org.apache.accumulo.core.data.PartialKey;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.accumulo.core.iterators.LongCombiner;
    +import org.apache.accumulo.core.iterators.user.SummingCombiner;
    +import org.apache.accumulo.core.security.Authorizations;
    +import org.apache.accumulo.harness.AccumuloClusterIT;
    +import org.apache.hadoop.io.Text;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.util.Map;
    +
    +/**
    + * Test writing to another table from inside an iterator.
    + *
    + * @see BatchWriterIterator
    + */
    +public class BatchWriterInTabletServerIT extends AccumuloClusterIT {
    --- End diff --
    
    Can you please add a
    ```
    @Override public boolean canRunTest(ClusterType type) {
      return ClusterType.MINI == type;
    }
    ```
    
    I don't want to rehash batchwriters in scanners again, but I'm worried about running safely against a standalone Accumulo cluster (and leaving the instance in a deadlocked state after this test finishes). If we only run it against miniclusters, at least it's isolated to just those processes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---