Return-Path: 
 <dev-return-14633-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 23E541994E
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Thu, 21 Apr 2016 14:17:13 +0000 (UTC)
Received: (qmail 69078 invoked by uid 500); 21 Apr 2016 14:17:13 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 69039 invoked by uid 500); 21 Apr 2016 14:17:13 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 69028 invoked by uid 99); 21 Apr 2016 14:17:12 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 14:17:12 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 95DDEDFD7B; Thu, 21 Apr 2016 14:17:12 +0000 (UTC)
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-95-accumulo@git.apache.org>
In-Reply-To: <git-pr-95-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-4195 Added generalized
 configurati...
Content-Type: text/plain
Message-Id: <20160421141712.95DDEDFD7B@git1-us-west.apache.org>
Date: Thu, 21 Apr 2016 14:17:12 +0000 (UTC)

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/95#discussion_r60587760
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/DispatchingFileFactory.java ---
    @@ -60,78 +54,54 @@ private FileOperations findFileFactory(String file) {
         }
       }
     
    -  @Override
    -  public FileSKVIterator openIndex(String file, FileSystem fs, Configuration conf, AccumuloConfiguration acuconf) throws IOException {
    -    return findFileFactory(file).openIndex(file, fs, conf, acuconf, null, null);
    -  }
    -
    -  @Override
    -  public FileSKVIterator openReader(String file, boolean seekToBeginning, FileSystem fs, Configuration conf, RateLimiter readLimiter,
    -      AccumuloConfiguration acuconf) throws IOException {
    -    FileSKVIterator iter = findFileFactory(file).openReader(file, seekToBeginning, fs, conf, readLimiter, acuconf, null, null);
    -    if (acuconf.getBoolean(Property.TABLE_BLOOM_ENABLED)) {
    -      return new BloomFilterLayer.Reader(iter, acuconf);
    +  /** If the table configuration disallows caching, rewrite the options object to not pass the caches. */
    +  private static <T extends FileReaderOperation<T>> T filterCaches(T input) {
    +    BlockCache indexCache = input.getIndexCache();
    +    BlockCache dataCache = input.getDataCache();
    +    if (!input.getTableConfiguration().getBoolean(Property.TABLE_INDEXCACHE_ENABLED)) {
    +      indexCache = null;
    --- End diff --
    
    Nevemind.  I thought this had no impact, but I was looking at the subtracted lines of the diff.  Now I see that it does have an impact.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---