Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ShawnWalker <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-94-accumulo@git.apache.org>
In-Reply-To: <git-pr-94-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-4191 Tracing on client can
 sometim...
Content-Type: text/plain
Message-Id: <20160415145929.89F2CDFFD9@git1-us-west.apache.org>
Date: Fri, 15 Apr 2016 14:59:29 +0000 (UTC)

Github user ShawnWalker commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/94#discussion_r59887691
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java ---
    @@ -733,7 +733,7 @@ else if (Tables.getTableState(context.getInstance(), table) == TableState.OFFLIN
         void queueMutations(final MutationSet mutationsToSend) throws InterruptedException {
           if (null == mutationsToSend)
             return;
    -      binningThreadPool.execute(new Runnable() {
    +      binningThreadPool.execute(Trace.wrap(new Runnable() {
    --- End diff --
    
    Looking at `org.apache.htrace.wrappers.TraceRunnable`, it's not really designed to be used as you're suggesting.  One would hope to be able to write:
    ```java
    threadPool.execute(new TraceRunnable() { ... })
    ```
    
    But the best that `TraceRunnable` allows is:
    ```java
    threadPool.execute(new TraceRunnable(new Runnable() {...}));
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---