Return-Path: 
 <dev-return-14570-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EFC0119D55
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Wed, 13 Apr 2016 18:05:03 +0000 (UTC)
Received: (qmail 33534 invoked by uid 500); 13 Apr 2016 18:05:03 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 33492 invoked by uid 500); 13 Apr 2016 18:05:03 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 33481 invoked by uid 99); 13 Apr 2016 18:05:03 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 18:05:03 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 64C07DFC70; Wed, 13 Apr 2016 18:05:03 +0000 (UTC)
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-90-accumulo@git.apache.org>
In-Reply-To: <git-pr-90-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-4187: Added rate limiting
 for majo...
Content-Type: text/plain
Message-Id: <20160413180503.64C07DFC70@git1-us-west.apache.org>
Date: Wed, 13 Apr 2016 18:05:03 +0000 (UTC)

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/90#discussion_r59596175
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/FileOperations.java ---
    @@ -55,23 +56,24 @@ public static FileOperations getInstance() {
        */
     
       public abstract FileSKVIterator openReader(String file, Range range, Set<ByteSequence> columnFamilies, boolean inclusive, FileSystem fs, Configuration conf,
    -      AccumuloConfiguration tableConf) throws IOException;
    +      RateLimiter readLimiter, AccumuloConfiguration tableConf) throws IOException;
     
       public abstract FileSKVIterator openReader(String file, Range range, Set<ByteSequence> columnFamilies, boolean inclusive, FileSystem fs, Configuration conf,
    -      AccumuloConfiguration tableConf, BlockCache dataCache, BlockCache indexCache) throws IOException;
    +      RateLimiter readLimiter, AccumuloConfiguration tableConf, BlockCache dataCache, BlockCache indexCache) throws IOException;
     
       /**
        * Open a reader that fully support seeking and also enable any optimizations related to seeking, like bloom filters.
        *
        */
     
    -  public abstract FileSKVIterator openReader(String file, boolean seekToBeginning, FileSystem fs, Configuration conf, AccumuloConfiguration acuconf)
    -      throws IOException;
    +  public abstract FileSKVIterator openReader(String file, boolean seekToBeginning, FileSystem fs, Configuration conf, RateLimiter readLimiter,
    --- End diff --
    
    > It sounds like you're advocating a more general refactoring of AccumuloConfiguration handling.
    
    Well, it's relevant in that without some change, you have `, null` sprinkled everywhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---