Return-Path: 
 <dev-return-14544-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 606B919F22
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Wed, 13 Apr 2016 04:16:01 +0000 (UTC)
Received: (qmail 52876 invoked by uid 500); 13 Apr 2016 04:16:01 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 52678 invoked by uid 500); 13 Apr 2016 04:16:00 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 52667 invoked by uid 99); 13 Apr 2016 04:16:00 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 04:16:00 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id AC047DFB7C; Wed, 13 Apr 2016 04:15:59 +0000 (UTC)
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-90-accumulo@git.apache.org>
In-Reply-To: <git-pr-90-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-4187: Added rate limiting
 for majo...
Content-Type: text/plain
Message-Id: <20160413041559.AC047DFB7C@git1-us-west.apache.org>
Date: Wed, 13 Apr 2016 04:15:59 +0000 (UTC)

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/90#issuecomment-209218793
  
    Made a first pass through the code. Wow! Great work for a first contribution @ShawnWalker! Some general themes:
    
    * nit-picky stylistic things
    * Missing javadoc on public classes/methods
    
    Some new tests on these new classes (testing the rate limiting components and input/output streams should be really important) would really make this even better.
    
    I'll have to go back to reread about the use of `<T extends Class & Interface>` littered everywhere with a fresh mind. First time I've run across it and I don't think I entirely grokked the point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---