Return-Path: 
 <dev-return-14476-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CCEB519BD3
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Mon,  4 Apr 2016 17:51:18 +0000 (UTC)
Received: (qmail 14704 invoked by uid 500); 4 Apr 2016 17:51:18 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 14664 invoked by uid 500); 4 Apr 2016 17:51:18 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 14653 invoked by uid 99); 4 Apr 2016 17:51:18 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Apr 2016 17:51:18 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 4B491DFDEC; Mon,  4 Apr 2016 17:51:18 +0000 (UTC)
From: ivakegg <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-87-accumulo@git.apache.org>
In-Reply-To: <git-pr-87-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-4178: Updated the sender
 thread to...
Content-Type: text/plain
Message-Id: <20160404175118.4B491DFDEC@git1-us-west.apache.org>
Date: Mon,  4 Apr 2016 17:51:18 +0000 (UTC)

Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/87#discussion_r58417479
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java ---
    @@ -831,11 +814,16 @@ public void send(TabletServerMutations<Mutation> tsm) throws AccumuloServerExcep
             try {
     
               long count = 0;
    -          for (List<Mutation> list : mutationBatch.values()) {
    -            count += list.size();
    +
    +          Set<Text> tableIds = new TreeSet<Text>();
    +          for (Map.Entry<KeyExtent,List<Mutation>> entry : mutationBatch.entrySet()) {
    +            count += entry.getValue().size();
    +            tableIds.add(entry.getKey().getTableId());
               }
    -          String msg = "sending " + String.format("%,d", count) + " mutations to " + String.format("%,d", mutationBatch.size()) + " tablets at " + location;
    -          Thread.currentThread().setName(msg);
    +          StringBuilder msg = new StringBuilder();
    +          msg.append("sending ").append(String.format("%,d", count)).append(" mutations to ").append(String.format("%,d", mutationBatch.size()))
    +              .append(" tablets for ").append(String.format("%,d", tableIds.size())).append(" tables ").append(tableIds).append(" to ").append(location);
    --- End diff --
    
    Also I agree including the number of table ids is redundant.  I will remove that part....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---