accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ShawnWalker <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4195 Added generalized configurati...
Date Tue, 19 Apr 2016 21:27:35 GMT
GitHub user ShawnWalker opened a pull request:

    https://github.com/apache/accumulo/pull/95

    ACCUMULO-4195 Added generalized configuration objects for RFile interaction

    Implemented a builder/fluent style of syntax, where each operation creates an operation
object with both some methods for setting
    parameters and an execute() method to actually invoke the operation.
    
    I'm not really sure if this is in line with the improvement the reporter suggests.  It
does however address the only goal I can identify with that request: it should be possible
to extend the interface `FileOperations` in a manner such as was done for ACCUMULO-4187 without
requiring significant changes to unrelated code.
    
    Also, the automatic formatter hates me, and completely undid most of my eye-pleasing formatting.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ShawnWalker/accumulo ACCUMULO-4195

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #95
    
----
commit 8917a37a4134a04bb47fac8e14320ea6f1916ed4
Author: Shawn Walker <accumulo@shawn-walker.net>
Date:   2016-04-19T19:54:31Z

    ACCUMULO-4195 Added generalized configuration objects for RFile interaction.
    
    Implemented a builder/fluent style of syntax, where each operation creates an operation
object with both some methods for setting
    parameters and an execute() method to actually invoke the operation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message