accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhutchis <>
Subject [GitHub] accumulo pull request: ACCUMULO-4229 BatchWriter Locator cache out...
Date Fri, 29 Apr 2016 18:51:12 GMT
Github user dhutchis commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/
    @@ -0,0 +1,124 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.client.impl;
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.Callable;
    +import org.apache.accumulo.core.client.AccumuloException;
    +import org.apache.accumulo.core.client.AccumuloSecurityException;
    +import org.apache.accumulo.core.client.Instance;
    +import org.apache.accumulo.core.client.TableNotFoundException;
    +import org.apache.log4j.Logger;
    + * Syncs itself with the static collection of TabletLocators, so that when the server
clears it, it will automatically get the most up-to-date version. Caching
    + * TabletLocators locally is safe when using SyncingTabletLocator.
    + */
    +public class SyncingTabletLocator extends TabletLocator {
    +  private static final Logger log = Logger.getLogger(SyncingTabletLocator.class);
    +  /*
    +   * Implementation: the invalidateCache calls do not need to call syncLocator because
it is okay if an outdated locator is invalidated. In this case, on the
    --- End diff --
    Hmm I suppose so.  Goofy code indeed.  In that case we could defensively call `syncLocator`
in the `invalidateCache` calls anyway.  Very little performance impact.  Will push this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message