accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4229 BatchWriter Locator cache out...
Date Fri, 29 Apr 2016 18:46:45 GMT
Github user keith-turner commented on the pull request:

    https://github.com/apache/accumulo/pull/96#issuecomment-215845672
  
    > Sadly I don't see an easy way to implement this behavior.
    
    I agree.
    
    >   It is simple and it works. Don't you think it is better to permit classes the privilege
of holding a reference?
    
    I can see pros and cons either way.   The con of having code that holds long term refs
is that we need the code in this PR, which is a little more code to maintain.  The pro of
having the code in this PR is that its more likely that new code using the tablet locator
going forward will not use it incorrectly (by holding a ref when it should not).  Personally
I am happy w/ either path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message