accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjwall <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4195 Added generalized configurati...
Date Wed, 27 Apr 2016 18:48:31 GMT
Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/95#discussion_r61314805
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloFileOutputFormat.java
---
    @@ -186,7 +186,8 @@ public void write(Key key, Value value) throws IOException {
             }
     
             if (out == null) {
    -          out = FileOperations.getInstance().openWriter(file.toString(), file.getFileSystem(conf),
conf, null, acuConf);
    +          out = FileOperations.getInstance().newWriterBuilder().forFile(file.toString(),
file.getFileSystem(conf), conf).withTableConfiguration(acuConf)
    --- End diff --
    
    Didn't look too closely, but it struck me this could be cleaned up with another constructor
that took a Path and  Configuration so it would read
    `
    out = FileOperations.getInstance().newWriterBuilder().forFile(file, conf).withTableConfiguration(acuConf)
    `
    Fine as is though


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message