accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ShawnWalker <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4195 Added generalized configurati...
Date Wed, 27 Apr 2016 16:19:19 GMT
Github user ShawnWalker commented on the pull request:

    https://github.com/apache/accumulo/pull/95#issuecomment-215136560
  
    I changed the method names to look more builder-ish as @joshelser suggested.  Wasn't quite
sure how the change the verbiage `getFileSize(...)`, so I left it alone.  
    
    I also dovetailled `NeedsFile` into `NeedsTableConfiguration`, cutting down the signature
of the factory methods somewhat.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message