accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4195 Added generalized configurati...
Date Mon, 25 Apr 2016 13:46:04 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/95#discussion_r60914702
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/FileOperations.java ---
    @@ -48,38 +48,295 @@ public static FileOperations getInstance() {
         return new DispatchingFileFactory();
       }
     
    +  //
    +  // Abstract methods (to be implemented by subclasses)
    +  //
    +
    +  protected abstract long getFileSize(GetFileSizeOperation options) throws IOException;
    +
    +  protected abstract FileSKVWriter openWriter(OpenWriterOperation options) throws IOException;
    +
    +  protected abstract FileSKVIterator openIndex(OpenIndexOperation options) throws IOException;
    +
    +  protected abstract FileSKVIterator openScanReader(OpenScanReaderOperation options)
throws IOException;
    +
    +  protected abstract FileSKVIterator openReader(OpenReaderOperation options) throws IOException;
    +
    +  //
    +  // File operations
    +  //
    +
       /**
    -   * Open a reader that will not be seeked giving an initial seek location. This is useful
for file operations that only need to scan data within a range and do
    -   * not need to seek. Therefore file metadata such as indexes does not need to be kept
in memory while the file is scanned. Also seek optimizations like bloom
    -   * filters do not need to be loaded.
    +   * Construct an operation object allowing one to query the size of a file. <br>
    +   * Syntax:
        *
    +   * <pre>
    +   * long size = fileOperations.getFileSize().ofFile(filename, fileSystem, fsConfiguration).withTableConfiguration(tableConf).execute();
    --- End diff --
    
    Yeah, sometime the formatter is a bit aggressive. You can disable it for some portion
of code by
    
    ```
    /* @formatter:off */
    ... my pre-formatted stuff...
    /* @formatter:on */
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message