accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4229 BatchWriter Locator cache out...
Date Sun, 24 Apr 2016 23:09:23 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/96#discussion_r60853624
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java
---
    @@ -329,6 +331,8 @@ private void processFailures(Map<KeyExtent,List<Range>>
failures, ResultReceiver
     
         // since the first call to binRanges clipped the ranges to within a tablet, we should
not get only
         // bin to the set of failed tablets
    +    if (!locator.isValid())
    +      locator = new TimeoutTabletLocator(TabletLocator.getLocator(instance, new Text(table)),
timeout);
    --- End diff --
    
    Using an AtomicReference might be more straightforward and more localized of a change
(avoids any potential lock contention on TSBRI.class)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message