accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4187: Added rate limiting for majo...
Date Mon, 18 Apr 2016 14:55:56 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/90#issuecomment-211414852
  
    I think everything I asked about has been taken care of. Thanks for that, Shawn.
    
    The only thing I don't see (and I didn't say it explicitly earlier, so I don't think it's
a blocker to merge this in) is a high-level test. I see you added some tests for the rate-limiter
piece. I'm wondering if we could make an integration test specifically to test this feature.
It's nice when we have a general test class (built around a minicluster) available so that
we can easily test potential bugs and add new tests easily.
    
    @keith-turner LMK if you have time to merge this in and run the tests. Otherwise, I'll
kick off something myself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message