accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivakegg <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4184: Fixed issues with the HostRe...
Date Thu, 14 Apr 2016 16:17:32 GMT
Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/93#discussion_r59746357
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
---
    @@ -56,18 +61,24 @@
      * <b>table.custom.balancer.host.regex.pool.check=5m</b><br>
      * Regex matching can be based on either the host name (default) or host ip address.
To set this balancer to match the regular expressions to the tablet server
      * IP address, then set the following property:<br>
    - * <b>table.custom.balancer.host.regex.is.ip=true</b>
    + * <b>table.custom.balancer.host.regex.is.ip=true</b><br>
    + * It's possible that this balancer may create a lot of migrations. To limit the number
of migrations that are created during a balance call, set the following
    + * property (default 250):<br>
    + * <b>table.custom.balancer.host.regex.concurrent.migrations</b>
      *
      */
    -public class HostRegexTableLoadBalancer extends TableLoadBalancer {
    +public class HostRegexTableLoadBalancer extends TableLoadBalancer implements ConfigurationObserver
{
     
       private static final Logger LOG = LoggerFactory.getLogger(HostRegexTableLoadBalancer.class);
       public static final String HOST_BALANCER_PREFIX = Property.TABLE_ARBITRARY_PROP_PREFIX.getKey()
+ "balancer.host.regex.";
    -  public static final String HOST_BALANCER_OOB_CHECK = Property.TABLE_ARBITRARY_PROP_PREFIX.getKey()
+ "balancer.host.regex.oob.period";
    +  public static final String HOST_BALANCER_OOB_CHECK_KEY = Property.TABLE_ARBITRARY_PROP_PREFIX.getKey()
+ "balancer.host.regex.oob.period";
    --- End diff --
    
    How many oobs does a host balancer have to check?  (in other words a more obvious property
name might be nice).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message