accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ShawnWalker <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4187: Added rate limiting for majo...
Date Wed, 13 Apr 2016 15:36:42 GMT
Github user ShawnWalker commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/90#discussion_r59571157
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/FileOperations.java ---
    @@ -55,23 +56,24 @@ public static FileOperations getInstance() {
        */
     
       public abstract FileSKVIterator openReader(String file, Range range, Set<ByteSequence>
columnFamilies, boolean inclusive, FileSystem fs, Configuration conf,
    -      AccumuloConfiguration tableConf) throws IOException;
    +      RateLimiter readLimiter, AccumuloConfiguration tableConf) throws IOException;
     
       public abstract FileSKVIterator openReader(String file, Range range, Set<ByteSequence>
columnFamilies, boolean inclusive, FileSystem fs, Configuration conf,
    -      AccumuloConfiguration tableConf, BlockCache dataCache, BlockCache indexCache) throws
IOException;
    +      RateLimiter readLimiter, AccumuloConfiguration tableConf, BlockCache dataCache,
BlockCache indexCache) throws IOException;
     
       /**
        * Open a reader that fully support seeking and also enable any optimizations related
to seeking, like bloom filters.
        *
        */
     
    -  public abstract FileSKVIterator openReader(String file, boolean seekToBeginning, FileSystem
fs, Configuration conf, AccumuloConfiguration acuconf)
    -      throws IOException;
    +  public abstract FileSKVIterator openReader(String file, boolean seekToBeginning, FileSystem
fs, Configuration conf, RateLimiter readLimiter,
    --- End diff --
    
    I was thinking perhaps a fluent syntax for opening readers/writers would make sense.
    
    E.g. so that it admits syntax like the following:
    ```java
    FileSKVIterator iterator=fileOperations.openReader(accumuloConfiguration)
        .ofFile(filename, fileSystem, fsConfiguration)
        .withRateLimiter(rateLimiter) // optional
        .withCache(dataCache, indexCache) // optional
        .forScanning(range, columnFamilies, inclusive);
    ```
    
    Unfortunately, introducing such a change seemed a bit much for the scope of what I wanted
to accomplish.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message