accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4187: Added rate limiting for majo...
Date Wed, 13 Apr 2016 04:15:59 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/90#issuecomment-209218793
  
    Made a first pass through the code. Wow! Great work for a first contribution @ShawnWalker!
Some general themes:
    
    * nit-picky stylistic things
    * Missing javadoc on public classes/methods
    
    Some new tests on these new classes (testing the rate limiting components and input/output
streams should be really important) would really make this even better.
    
    I'll have to go back to reread about the use of `<T extends Class & Interface>`
littered everywhere with a fresh mind. First time I've run across it and I don't think I entirely
grokked the point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message