accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4187: Added rate limiting for majo...
Date Wed, 13 Apr 2016 03:44:13 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/90#discussion_r59489344
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java
---
    @@ -139,11 +146,12 @@ public long getStartPos() throws IOException {
        *
        */
       public static class Reader implements BlockFileReader {
    +    private final RateLimiter readLimiter;
         private BCFile.Reader _bc;
         private String fileName = "not_available";
         private BlockCache _dCache = null;
         private BlockCache _iCache = null;
    -    private FSDataInputStream fin = null;
    +    private Closeable fin = null;
    --- End diff --
    
    Any reason for `Closeable` instead of `InputStream`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message