accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4178: Updated the sender thread to...
Date Mon, 04 Apr 2016 14:22:14 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/87#discussion_r58382980
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
    @@ -16,37 +16,7 @@
      */
     package org.apache.accumulo.core.client.impl;
     
    -import java.io.IOException;
    --- End diff --
    
    What did you use for import manipulation?  I don't think the Accumulo project has declared
how imports have been organized.  However I think we do try to organize imports using Eclipse's
default settings inorder to cut down on noise generated by different IDEs organizing imports
in different ways.  Can we just drop this portion of the patch?  Did the code add any imports?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message